From 179e912fff4b403f3f7d8fe93bf7561e0af7170a Mon Sep 17 00:00:00 2001 From: fujr Date: Thu, 24 Oct 2024 17:58:51 +0800 Subject: [PATCH] Refactor modem_dial.sh to fix command line error and add debug logging --- .../root/usr/share/qmodem/modem_dial.sh | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/luci/luci-app-qmodem/root/usr/share/qmodem/modem_dial.sh b/luci/luci-app-qmodem/root/usr/share/qmodem/modem_dial.sh index 117001a..1857901 100755 --- a/luci/luci-app-qmodem/root/usr/share/qmodem/modem_dial.sh +++ b/luci/luci-app-qmodem/root/usr/share/qmodem/modem_dial.sh @@ -536,7 +536,7 @@ mhi_dial() qmi_dial() { cmd_line="quectel-CM" - [ -e "/usr/bin/quectel-CM-M" ] cmd_line="quectel-CM-M" + [ -e "/usr/bin/quectel-CM-M" ] && cmd_line="quectel-CM-M" case $pdp_type in "ip") cmd_line="$cmd_line -4" ;; "ipv6") cmd_line="$cmd_line -6" ;; @@ -564,8 +564,13 @@ qmi_dial() qmi_if=$(echo "$modem_netcard" | cut -d. -f1) cmd_line="${cmd_line} -i ${qmi_if}" fi - [ -e "/usr/bin/quectel-CM-M" ] && [ -n "$metric" ] && cmd_line="$cmd_line -M $metric" - [ -e "/usr/bin/quectel-CM-M" ] && cmd_line="$cmd_line -f $log_file" || cmd_line="$cmd_line -d -f $log_file" + if [ -e "/usr/bin/quectel-CM-M" ];then + [ -n "$metric" ] && cmd_line="$cmd_line -M $metric" + else + [ -n "$metric" ] && cmd_line="$cmd_line -d" + fi + cmd_line="$cmd_line -f $log_file" + m_debug "dialing $cmd_line" $cmd_line