From 7d01c798fd42f8dcf4b0126020b4ab978a78bc64 Mon Sep 17 00:00:00 2001
From: sbwml <admin@cooluc.com>
Date: Wed, 27 Sep 2023 14:20:20 +0800
Subject: [PATCH] luci-app-mosdns: fix multiple restart when database update

---
 luci-app-mosdns/root/usr/share/mosdns/mosdns.sh | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/luci-app-mosdns/root/usr/share/mosdns/mosdns.sh b/luci-app-mosdns/root/usr/share/mosdns/mosdns.sh
index 3b6c553..6625276 100755
--- a/luci-app-mosdns/root/usr/share/mosdns/mosdns.sh
+++ b/luci-app-mosdns/root/usr/share/mosdns/mosdns.sh
@@ -52,7 +52,7 @@ get_adlist() (
     fi
 )
 
-adlist_update() (
+adlist_update() {
     [ "$(uci -q get mosdns.config.adblock)" != 1 ] && exit 0
     ad_source=$(uci -q get mosdns.config.ad_source)
     AD_TMPDIR=$(mktemp -d) || exit 1
@@ -83,10 +83,9 @@ adlist_update() (
             rm -rf /etc/mosdns/rule/adlist/*
             \cp $AD_TMPDIR/* /etc/mosdns/rule/adlist
             rm -rf "$AD_TMPDIR"
-            restart_service
         }
     fi
-)
+}
 
 geodat_update() (
     TMPDIR=$(mktemp -d) || exit 1
@@ -120,7 +119,7 @@ geodat_update() (
         exit 1
     fi
     rm -rf "$TMPDIR"/*.sha256sum
-    cp -f "$TMPDIR"/* /usr/share/v2ray
+    \cp -a "$TMPDIR"/* /usr/share/v2ray
     rm -rf "$TMPDIR"
 )
 
@@ -179,7 +178,7 @@ case $script_action in
         logfile_path
     ;;
     "adlist_update")
-        adlist_update
+        adlist_update && [ "$has_update" -eq 1 ] && restart_service
     ;;
     "ecs_remote")
         ecs_remote